Disable some PosixSignalRegistration tests on mobile targets#55569
Merged
stephentoub merged 1 commit intodotnet:mainfrom Jul 13, 2021
Merged
Disable some PosixSignalRegistration tests on mobile targets#55569stephentoub merged 1 commit intodotnet:mainfrom
stephentoub merged 1 commit intodotnet:mainfrom
Conversation
xunit doesn't like the fact that some of these MemberDatas were yielding 0 entries on these platforms.
jkotas
approved these changes
Jul 13, 2021
steveisok
approved these changes
Jul 13, 2021
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Jul 14, 2021
dotnet#55569 didn't fix the issue since xunit retrieves the MemberData and checks for non-empty *before* evaluating the ConditionalTheory condition.
akoeplinger
added a commit
that referenced
this pull request
Jul 14, 2021
#55569 didn't fix the issue since xunit retrieves the MemberData and checks for non-empty *before* evaluating the ConditionalTheory condition.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xunit doesn't like the fact that some of these MemberDatas were yielding 0 entries on these platforms.
Fixes #55563